Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
index 9a02f3fb1cff7d98ba66797ea9d0375f26b3d201..dd76d0a43b3f96cdfa579d1ca2facb763f37246f 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
@@ -108,19 +108,20 @@ class CORE_EXPORT InspectorPageAgent final
static String cachedResourceTypeJson(const Resource&);
// Page API for frontend
- Response enable() override;
- Response disable() override;
- Response addScriptToEvaluateOnLoad(const String& scriptSource,
- String* identifier) override;
- Response removeScriptToEvaluateOnLoad(const String& identifier) override;
- Response setAutoAttachToCreatedPages(bool) override;
- Response reload(Maybe<bool> bypassCache,
- Maybe<String> scriptToEvaluateOnLoad) override;
- Response navigate(const String& url,
- Maybe<String> referrer,
- String* frameId) override;
- Response stopLoading() override;
- Response getResourceTree(
+ protocol::Response enable() override;
+ protocol::Response disable() override;
+ protocol::Response addScriptToEvaluateOnLoad(const String& scriptSource,
+ String* identifier) override;
+ protocol::Response removeScriptToEvaluateOnLoad(
+ const String& identifier) override;
+ protocol::Response setAutoAttachToCreatedPages(bool) override;
+ protocol::Response reload(Maybe<bool> bypassCache,
+ Maybe<String> scriptToEvaluateOnLoad) override;
+ protocol::Response navigate(const String& url,
+ Maybe<String> referrer,
+ String* frameId) override;
+ protocol::Response stopLoading() override;
+ protocol::Response getResourceTree(
std::unique_ptr<protocol::Page::FrameResourceTree>* frameTree) override;
void getResourceContent(const String& frameId,
const String& url,
@@ -131,19 +132,20 @@ class CORE_EXPORT InspectorPageAgent final
Maybe<bool> caseSensitive,
Maybe<bool> isRegex,
std::unique_ptr<SearchInResourceCallback>) override;
- Response setDocumentContent(const String& frameId,
- const String& html) override;
- Response startScreencast(Maybe<String> format,
- Maybe<int> quality,
- Maybe<int> maxWidth,
- Maybe<int> maxHeight,
- Maybe<int> everyNthFrame) override;
- Response stopScreencast() override;
- Response configureOverlay(Maybe<bool> suspended,
- Maybe<String> message) override;
- Response getLayoutMetrics(std::unique_ptr<protocol::Page::LayoutViewport>*,
- std::unique_ptr<protocol::Page::VisualViewport>*,
- std::unique_ptr<protocol::DOM::Rect>*) override;
+ protocol::Response setDocumentContent(const String& frameId,
+ const String& html) override;
+ protocol::Response startScreencast(Maybe<String> format,
+ Maybe<int> quality,
+ Maybe<int> maxWidth,
+ Maybe<int> maxHeight,
+ Maybe<int> everyNthFrame) override;
+ protocol::Response stopScreencast() override;
+ protocol::Response configureOverlay(Maybe<bool> suspended,
+ Maybe<String> message) override;
+ protocol::Response getLayoutMetrics(
+ std::unique_ptr<protocol::Page::LayoutViewport>*,
+ std::unique_ptr<protocol::Page::VisualViewport>*,
+ std::unique_ptr<protocol::DOM::Rect>*) override;
// InspectorInstrumentation API
void didClearDocumentOfWindowObject(LocalFrame*);

Powered by Google App Engine
This is Rietveld 408576698