third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h - Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h

index 1a6d110774cc811cdd91b545cfa5619c92eb7e39..27c64e36389998aafb46f33dea9ffbf539ed3212 100644

--- a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h

+++ b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h

@@ -53,8 +53,8 @@ class MODULES_EXPORT InspectorIndexedDBAgent final

void didCommitLoadForLocalFrame(LocalFrame*) override;

// Called from the front-end.

- Response enable() override;

- Response disable() override;

+ protocol::Response enable() override;

+ protocol::Response disable() override;

void requestDatabaseNames(

const String& securityOrigin,

std::unique_ptr<RequestDatabaseNamesCallback>) override;

@@ -67,7 +67,7 @@ class MODULES_EXPORT InspectorIndexedDBAgent final

const String& indexName,

int skipCount,

int pageSize,

- Maybe<protocol::IndexedDB::KeyRange>,

+ protocol::Maybe<protocol::IndexedDB::KeyRange>,

std::unique_ptr<RequestDataCallback>) override;

void clearObjectStore(const String& securityOrigin,

const String& databaseName,