third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h - Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

index 79c1aa62ce1cbb00c5edb7e85cffc6fd61612b5a..e962ef191d31f4cb3fe19328de3431e99cd08612 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h

@@ -24,10 +24,12 @@ class MODULES_EXPORT DeviceOrientationInspectorAgent final

DECLARE_VIRTUAL_TRACE();

// Protocol methods.

- Response setDeviceOrientationOverride(double, double, double) override;

- Response clearDeviceOrientationOverride() override;

+ protocol::Response setDeviceOrientationOverride(double,

+ double,

+ double) override;

+ protocol::Response clearDeviceOrientationOverride() override;

- Response disable() override;

+ protocol::Response disable() override;

void restore() override;

void didCommitLoadForLocalFrame(LocalFrame*) override;