Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 StorageType, 58 StorageType,
59 SecurityOrigin*); 59 SecurityOrigin*);
60 60
61 private: 61 private:
62 explicit InspectorDOMStorageAgent(Page*); 62 explicit InspectorDOMStorageAgent(Page*);
63 63
64 // InspectorBaseAgent overrides. 64 // InspectorBaseAgent overrides.
65 void restore() override; 65 void restore() override;
66 66
67 // protocol::Dispatcher::DOMStorageCommandHandler overrides. 67 // protocol::Dispatcher::DOMStorageCommandHandler overrides.
68 Response enable() override; 68 protocol::Response enable() override;
69 Response disable() override; 69 protocol::Response disable() override;
70 Response clear(std::unique_ptr<protocol::DOMStorage::StorageId>) override; 70 protocol::Response clear(
71 std::unique_ptr<protocol::DOMStorage::StorageId>) override;
71 72
72 Response getDOMStorageItems( 73 protocol::Response getDOMStorageItems(
73 std::unique_ptr<protocol::DOMStorage::StorageId>, 74 std::unique_ptr<protocol::DOMStorage::StorageId>,
74 std::unique_ptr<protocol::Array<protocol::Array<String>>>* entries) 75 std::unique_ptr<protocol::Array<protocol::Array<String>>>* entries)
75 override; 76 override;
76 Response setDOMStorageItem(std::unique_ptr<protocol::DOMStorage::StorageId>, 77 protocol::Response setDOMStorageItem(
77 const String& key, 78 std::unique_ptr<protocol::DOMStorage::StorageId>,
78 const String& value) override; 79 const String& key,
79 Response removeDOMStorageItem( 80 const String& value) override;
81 protocol::Response removeDOMStorageItem(
80 std::unique_ptr<protocol::DOMStorage::StorageId>, 82 std::unique_ptr<protocol::DOMStorage::StorageId>,
81 const String& key) override; 83 const String& key) override;
82 84
83 Response findStorageArea(std::unique_ptr<protocol::DOMStorage::StorageId>, 85 protocol::Response findStorageArea(
84 LocalFrame*&, 86 std::unique_ptr<protocol::DOMStorage::StorageId>,
85 StorageArea*&); 87 LocalFrame*&,
88 StorageArea*&);
86 std::unique_ptr<protocol::DOMStorage::StorageId> storageId( 89 std::unique_ptr<protocol::DOMStorage::StorageId> storageId(
87 SecurityOrigin*, 90 SecurityOrigin*,
88 bool isLocalStorage); 91 bool isLocalStorage);
89 92
90 Member<Page> m_page; 93 Member<Page> m_page;
91 bool m_isEnabled; 94 bool m_isEnabled;
92 }; 95 };
93 96
94 } // namespace blink 97 } // namespace blink
95 98
96 #endif // !defined(InspectorDOMStorageAgent_h) 99 #endif // !defined(InspectorDOMStorageAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698