Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 : public InspectorBaseAgent<protocol::Database::Metainfo> { 47 : public InspectorBaseAgent<protocol::Database::Metainfo> {
48 WTF_MAKE_NONCOPYABLE(InspectorDatabaseAgent); 48 WTF_MAKE_NONCOPYABLE(InspectorDatabaseAgent);
49 49
50 public: 50 public:
51 static InspectorDatabaseAgent* create(Page* page) { 51 static InspectorDatabaseAgent* create(Page* page) {
52 return new InspectorDatabaseAgent(page); 52 return new InspectorDatabaseAgent(page);
53 } 53 }
54 ~InspectorDatabaseAgent() override; 54 ~InspectorDatabaseAgent() override;
55 DECLARE_VIRTUAL_TRACE(); 55 DECLARE_VIRTUAL_TRACE();
56 56
57 Response disable() override; 57 protocol::Response disable() override;
58 void restore() override; 58 void restore() override;
59 void didCommitLoadForLocalFrame(LocalFrame*) override; 59 void didCommitLoadForLocalFrame(LocalFrame*) override;
60 60
61 // Called from the front-end. 61 // Called from the front-end.
62 Response enable() override; 62 protocol::Response enable() override;
63 Response getDatabaseTableNames( 63 protocol::Response getDatabaseTableNames(
64 const String& databaseId, 64 const String& databaseId,
65 std::unique_ptr<protocol::Array<String>>* names) override; 65 std::unique_ptr<protocol::Array<String>>* names) override;
66 void executeSQL(const String& databaseId, 66 void executeSQL(const String& databaseId,
67 const String& query, 67 const String& query,
68 std::unique_ptr<ExecuteSQLCallback>) override; 68 std::unique_ptr<ExecuteSQLCallback>) override;
69 69
70 void didOpenDatabase(blink::Database*, 70 void didOpenDatabase(blink::Database*,
71 const String& domain, 71 const String& domain,
72 const String& name, 72 const String& name,
73 const String& version); 73 const String& version);
74 74
75 private: 75 private:
76 explicit InspectorDatabaseAgent(Page*); 76 explicit InspectorDatabaseAgent(Page*);
77 void registerDatabaseOnCreation(blink::Database*); 77 void registerDatabaseOnCreation(blink::Database*);
78 78
79 blink::Database* databaseForId(const String& databaseId); 79 blink::Database* databaseForId(const String& databaseId);
80 InspectorDatabaseResource* findByFileName(const String& fileName); 80 InspectorDatabaseResource* findByFileName(const String& fileName);
81 81
82 Member<Page> m_page; 82 Member<Page> m_page;
83 typedef HeapHashMap<String, Member<InspectorDatabaseResource>> 83 typedef HeapHashMap<String, Member<InspectorDatabaseResource>>
84 DatabaseResourcesHeapMap; 84 DatabaseResourcesHeapMap;
85 DatabaseResourcesHeapMap m_resources; 85 DatabaseResourcesHeapMap m_resources;
86 bool m_enabled; 86 bool m_enabled;
87 }; 87 };
88 88
89 } // namespace blink 89 } // namespace blink
90 90
91 #endif // !defined(InspectorDatabaseAgent_h) 91 #endif // !defined(InspectorDatabaseAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698