Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: third_party/WebKit/Source/web/InspectorEmulationAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorEmulationAgent.h
diff --git a/third_party/WebKit/Source/web/InspectorEmulationAgent.h b/third_party/WebKit/Source/web/InspectorEmulationAgent.h
index b54b486056f01d16c4b8176131167a9b74522931..4b8a577b453f3e547ff9d1c7c3775a1765b1b0c2 100644
--- a/third_party/WebKit/Source/web/InspectorEmulationAgent.h
+++ b/third_party/WebKit/Source/web/InspectorEmulationAgent.h
@@ -36,22 +36,24 @@ class InspectorEmulationAgent final
~InspectorEmulationAgent() override;
// protocol::Dispatcher::EmulationCommandHandler implementation.
- Response forceViewport(double x, double y, double scale) override;
- Response resetViewport() override;
- Response resetPageScaleFactor() override;
- Response setPageScaleFactor(double) override;
- Response setScriptExecutionDisabled(bool value) override;
- Response setTouchEmulationEnabled(bool enabled,
- Maybe<String> configuration) override;
- Response setEmulatedMedia(const String&) override;
- Response setCPUThrottlingRate(double) override;
- Response setVirtualTimePolicy(const String& policy,
- Maybe<int> virtualTimeBudgetMs) override;
- Response setDefaultBackgroundColorOverride(
- Maybe<protocol::DOM::RGBA>) override;
+ protocol::Response forceViewport(double x, double y, double scale) override;
+ protocol::Response resetViewport() override;
+ protocol::Response resetPageScaleFactor() override;
+ protocol::Response setPageScaleFactor(double) override;
+ protocol::Response setScriptExecutionDisabled(bool value) override;
+ protocol::Response setTouchEmulationEnabled(
+ bool enabled,
+ protocol::Maybe<String> configuration) override;
+ protocol::Response setEmulatedMedia(const String&) override;
+ protocol::Response setCPUThrottlingRate(double) override;
+ protocol::Response setVirtualTimePolicy(
+ const String& policy,
+ protocol::Maybe<int> virtualTimeBudgetMs) override;
+ protocol::Response setDefaultBackgroundColorOverride(
+ protocol::Maybe<protocol::DOM::RGBA>) override;
// InspectorBaseAgent overrides.
- Response disable() override;
+ protocol::Response disable() override;
void restore() override;
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698