Ensure locations are always provided, but don't store them yet.

Ensure locations are always provided, but don't store them yet.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/ee7a3e1e24cc63fbd3f75dabd01d64b87e29948f

[ahe, 2017-02-10 14:34:29]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2017-02-10 14:34:29]

This was a bit more work than I expected. I found when I started compiling the
patched SDK that missing information about source locations made it hard for me
to figure out what was going on, so I added an ad-hoc mechanism.

Generalizing that mechanism became this monster CL :-(
Fortunately, this is information that needs to be available and now we don't
have to add it later.

I've measured that compiling dart2js with fasta isn't affected by this change.
At some point in the future I need to investigate what the cost of adding two
additional fields to Builder is.

[ahe, 2017-02-10 15:35:18]

Note: I uploaded a new patch set as I found some problems during testing.

[Johnni Winther, 2017-02-13 08:42:03]

lgtm

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:53: : uri = uri,
super(uri);
Isn't initializing formal also parameters now by default?

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:914: new
KernelVariableBuilder(variable, member ?? classBuilder);
Should it be `member ?? classBuilder ?? library` ?

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1729: new
KernelVariableBuilder(variable, member ?? classBuilder);
Ditto.

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart (right):

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart:254:
returnType, name, typeVariables, formals, null, -1)
Set [fileUri] on this?

[ahe, 2017-02-13 10:44:23]

Thank you, Johnni!

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart (right):

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart:53: : uri = uri,
super(uri);
On 2017/02/13 08:42:03, Johnni Winther wrote:
> Isn't initializing formal also parameters now by default?

I don't know. I'd like  to be able to continue performance testing this on a
Dart VM from November.

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:914: new
KernelVariableBuilder(variable, member ?? classBuilder);
On 2017/02/13 08:42:03, Johnni Winther wrote:
> Should it be `member ?? classBuilder ?? library` ?

I've added a TODO. It should be the current part, not library, but I don't have
an object to represent it.

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1729: new
KernelVariableBuilder(variable, member ?? classBuilder);
On 2017/02/13 08:42:03, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart (right):

https://codereview.chromium.org/2691523002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart:254:
returnType, name, typeVariables, formals, null, -1)
On 2017/02/13 08:42:03, Johnni Winther wrote:
> Set [fileUri] on this?

This code is removed by CL 2682333004.

[ahe, 2017-02-13 11:30:29]

Description was changed from

==========
Ensure locations are always provided, but don't store them yet.
==========

to

==========
Ensure locations are always provided, but don't store them yet.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ee7a3e1e24cc63fbd3f75dabd01d64b87e29948f
==========

[ahe, 2017-02-13 11:30:32]

Committed patchset #4 (id:60001) manually as
ee7a3e1e24cc63fbd3f75dabd01d64b87e29948f (presubmit successful).