pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart - Issue 2691523002: Ensure locations are always provided, but don't store them yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)

Patch Set: Address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

index e435d734a8c2fcf1def35d05091520b6d7ab55a4..d891e8e120f33bfbd3bc60eec8e6a30cf4d60441 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

@@ -10,6 +10,7 @@ import 'package:kernel/ast.dart' show

import 'kernel_builder.dart' show

FormalParameterBuilder,

+ KernelLibraryBuilder,

KernelTypeBuilder,

MetadataBuilder;

@@ -19,8 +20,9 @@ class KernelFormalParameterBuilder

KernelFormalParameterBuilder(List<MetadataBuilder> metadata,

int modifiers, KernelTypeBuilder type, String name,

- bool hasThis)

- : super (metadata, modifiers, type, name, hasThis);

+ bool hasThis, KernelLibraryBuilder compilationUnit, int charOffset)

+ : super (metadata, modifiers, type, name, hasThis, compilationUnit,

+ charOffset);

VariableDeclaration build() {

return declaration ??= new VariableDeclaration(