Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: pkg/front_end/lib/src/fasta/builder/named_type_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
index b8232bc3395f5a54743796c44a1dec27461780a7..4b9e3230352986272282ce0320beb7a4ec34b7e8 100644
--- a/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
@@ -23,7 +23,8 @@ abstract class NamedTypeBuilder<T extends TypeBuilder> extends TypeBuilder {
void set builder(TypeDeclarationBuilder b);
- NamedTypeBuilder(this.name, this.arguments);
+ NamedTypeBuilder(this.name, this.arguments, int charOffset, Uri fileUri)
+ : super(charOffset, fileUri);
InvalidTypeBuilder buildInvalidType(String name);
@@ -32,7 +33,7 @@ abstract class NamedTypeBuilder<T extends TypeBuilder> extends TypeBuilder {
}
void resolveIn(Scope scope) {
- Builder member = scope.lookup(name);
+ Builder member = scope.lookup(name, charOffset, fileUri);
if (member is TypeDeclarationBuilder) {
builder = member;
return;
@@ -41,7 +42,7 @@ abstract class NamedTypeBuilder<T extends TypeBuilder> extends TypeBuilder {
int index = name.lastIndexOf(".");
String first = name.substring(0, index);
String last = name.substring(name.lastIndexOf(".") + 1);
- var prefix = scope.lookup(first);
+ var prefix = scope.lookup(first, charOffset, fileUri);
if (prefix is PrefixBuilder) {
member = prefix.exports[last];
}

Powered by Google App Engine
This is Rietveld 408576698