Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: pkg/front_end/lib/src/fasta/builder/library_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/library_builder.dart b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
index 1d3476eb48614baa2fb118661b90bdc3452b37f4..16e6b43ba27ea5dc85ebf60ce8399734426fa94f 100644
--- a/pkg/front_end/lib/src/fasta/builder/library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
@@ -44,10 +44,14 @@ abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
Map<String, Builder> get exports;
+ LibraryBuilder(Uri fileUri)
+ : super(null, -1, fileUri);
+
Builder addBuilder(String name, Builder builder);
- void addExporter(LibraryBuilder exporter, List<Combinator> combinators) {
- exporters.add(new Export(exporter, this, combinators));
+ void addExporter(LibraryBuilder exporter, List<Combinator> combinators,
+ int charOffset) {
+ exporters.add(new Export(exporter, this, combinators, charOffset));
}
void addCompileTimeError(int charOffset, Object message) {
@@ -61,7 +65,7 @@ abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
void addToScope(String name, Builder member);
InvalidTypeBuilder buildAmbiguousBuilder(
- String name, Builder builder, Builder other);
+ String name, Builder builder, Builder other, int charOffset);
int finishStaticInvocations() => 0;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/invalid_type_builder.dart ('k') | pkg/front_end/lib/src/fasta/builder/member_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698