Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.dill_member_builder; 5 library fasta.dill_member_builder;
6 6
7 import 'package:kernel/ast.dart' show 7 import 'package:kernel/ast.dart' show
8 Constructor, 8 Constructor,
9 Field, 9 Field,
10 Member, 10 Member,
(...skipping 12 matching lines...) Expand all
23 constMask, 23 constMask,
24 externalMask, 24 externalMask,
25 finalMask, 25 finalMask,
26 staticMask; 26 staticMask;
27 27
28 class DillMemberBuilder extends MemberBuilder { 28 class DillMemberBuilder extends MemberBuilder {
29 final int modifiers; 29 final int modifiers;
30 30
31 final Member member; 31 final Member member;
32 32
33 final Builder parent; 33 DillMemberBuilder(Member member, Builder parent)
34
35 DillMemberBuilder(Member member, this.parent)
36 : modifiers = computeModifiers(member), 34 : modifiers = computeModifiers(member),
37 member = member; 35 member = member,
36 super(parent, member.fileOffset);
38 37
39 Member get target => member; 38 Member get target => member;
40 39
41 bool get isConstructor => member is Constructor; 40 bool get isConstructor => member is Constructor;
42 41
43 bool get isFactory { 42 bool get isFactory {
44 if (member is Procedure) { 43 if (member is Procedure) {
45 Procedure procedure = member; 44 Procedure procedure = member;
46 return procedure.kind == ProcedureKind.Factory; 45 return procedure.kind == ProcedureKind.Factory;
47 } else { 46 } else {
(...skipping 12 matching lines...) Expand all
60 } else if (member is Procedure) { 59 } else if (member is Procedure) {
61 modifier |= member.isConst ? constMask : 0; 60 modifier |= member.isConst ? constMask : 0;
62 modifier |= member.isStatic ? staticMask : 0; 61 modifier |= member.isStatic ? staticMask : 0;
63 } else if (member is Constructor) { 62 } else if (member is Constructor) {
64 modifier |= member.isConst ? constMask : 0; 63 modifier |= member.isConst ? constMask : 0;
65 } else { 64 } else {
66 internalError("Unhandled: ${member.runtimeType}"); 65 internalError("Unhandled: ${member.runtimeType}");
67 } 66 }
68 return modifier; 67 return modifier;
69 } 68 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart ('k') | pkg/front_end/lib/src/fasta/errors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698