Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2792)

Unified Diff: pkg/front_end/lib/src/fasta/builder/class_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/class_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/class_builder.dart b/pkg/front_end/lib/src/fasta/builder/class_builder.dart
index 5e3bfdf417c3c6c8eb1ab295a17d5087b93423f2..ea3bb3f3959e4b77493f00e6faede1f133b33d18 100644
--- a/pkg/front_end/lib/src/fasta/builder/class_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/class_builder.dart
@@ -30,8 +30,8 @@ abstract class ClassBuilder<T extends TypeBuilder, R>
ClassBuilder(
List<MetadataBuilder> metadata, int modifiers,
String name, this.typeVariables, this.supertype, this.interfaces,
- this.members, List<T> types, LibraryBuilder parent)
- : super(metadata, modifiers, name, types, parent);
+ this.members, List<T> types, LibraryBuilder parent, int charOffset)
+ : super(metadata, modifiers, name, types, parent, charOffset);
List<ConstructorReferenceBuilder> get constructorReferences => null;
@@ -73,7 +73,8 @@ abstract class ClassBuilder<T extends TypeBuilder, R>
}
/// Used to lookup a static member of this class.
- Builder findStaticBuilder(String name, {bool isSetter: false}) {
+ Builder findStaticBuilder(String name, int charOffset, Uri fileUri,
+ {bool isSetter: false}) {
Builder builder = members[name];
if (builder?.next != null) {
Builder getterBuilder;
@@ -85,7 +86,7 @@ abstract class ClassBuilder<T extends TypeBuilder, R>
} else if (current.isSetter && setterBuilder == null) {
setterBuilder = current;
} else {
- return new AmbiguousBuilder(builder);
+ return new AmbiguousBuilder(builder, charOffset, fileUri);
}
current = current.next;
}

Powered by Google App Engine
This is Rietveld 408576698