Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Missing file. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.dill_library_builder; 5 library fasta.dill_library_builder;
6 6
7 import 'package:kernel/ast.dart' show 7 import 'package:kernel/ast.dart' show
8 Class, 8 Class,
9 ExpressionStatement, 9 ExpressionStatement,
10 Field, 10 Field,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 final Map<String, Builder> members = <String, Builder>{}; 43 final Map<String, Builder> members = <String, Builder>{};
44 44
45 // TODO(ahe): Some export information needs to be serialized. 45 // TODO(ahe): Some export information needs to be serialized.
46 final Map<String, Builder> exports = <String, Builder>{}; 46 final Map<String, Builder> exports = <String, Builder>{};
47 47
48 final DillLoader loader; 48 final DillLoader loader;
49 49
50 Library library; 50 Library library;
51 51
52 DillLibraryBuilder(this.uri, this.loader); 52 DillLibraryBuilder(Uri uri, this.loader)
53 : uri = uri, super(uri);
Johnni Winther 2017/02/13 08:42:03 Isn't initializing formal also parameters now by d
ahe 2017/02/13 10:44:23 I don't know. I'd like to be able to continue per
53 54
54 get scope => internalError("Scope not supported"); 55 get scope => internalError("Scope not supported");
55 56
56 Uri get fileUri => uri; 57 Uri get fileUri => uri;
57 58
58 void addClass(Class cls) { 59 void addClass(Class cls) {
59 DillClassBuilder classBulder = new DillClassBuilder(cls, this); 60 DillClassBuilder classBulder = new DillClassBuilder(cls, this);
60 addBuilder(cls.name, classBulder); 61 addBuilder(cls.name, classBulder);
61 cls.procedures.forEach(classBulder.addMember); 62 cls.procedures.forEach(classBulder.addMember);
62 cls.constructors.forEach(classBulder.addMember); 63 cls.constructors.forEach(classBulder.addMember);
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 106
106 bool addToExportScope(String name, Builder member) { 107 bool addToExportScope(String name, Builder member) {
107 return internalError("Not implemented yet."); 108 return internalError("Not implemented yet.");
108 } 109 }
109 110
110 void addToScope(String name, Builder member) { 111 void addToScope(String name, Builder member) {
111 internalError("Not implemented yet."); 112 internalError("Not implemented yet.");
112 } 113 }
113 114
114 KernelInvalidTypeBuilder buildAmbiguousBuilder( 115 KernelInvalidTypeBuilder buildAmbiguousBuilder(
115 String name, Builder builder, Builder other) { 116 String name, Builder builder, Builder other, int charOffset) {
116 return new KernelInvalidTypeBuilder(name, this); 117 return new KernelInvalidTypeBuilder(name, charOffset, fileUri);
117 } 118 }
118 } 119 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698