Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: pkg/front_end/lib/src/fasta/builder/metadata_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.metadata_builder; 5 library fasta.metadata_builder;
6 6
7 import 'builder.dart' show 7 import 'builder.dart' show
8 Builder, 8 Builder,
9 TypeBuilder; 9 TypeBuilder;
10 10
11 import 'constructor_reference_builder.dart' show 11 import 'constructor_reference_builder.dart' show
12 ConstructorReferenceBuilder; 12 ConstructorReferenceBuilder;
13 13
14 abstract class MetadataBuilder<T extends TypeBuilder> extends Builder { 14 abstract class MetadataBuilder<T extends TypeBuilder> extends Builder {
15 MetadataBuilder(); 15 MetadataBuilder(Builder parent, int charOffset)
16 : super(parent, -1, parent.fileUri);
16 17
17 factory MetadataBuilder.fromConstructor( 18 factory MetadataBuilder.fromConstructor(
18 ConstructorReferenceBuilder constructorReference, List arguments) { 19 ConstructorReferenceBuilder constructorReference, List arguments,
19 return new ConstructorMetadataBuilder(constructorReference, arguments); 20 Builder parent, int charOffset) {
21 return new ConstructorMetadataBuilder(constructorReference, arguments,
22 parent, charOffset);
20 } 23 }
21 24
22 factory MetadataBuilder.fromExpression(String expression, String postfix) { 25 factory MetadataBuilder.fromExpression(String expression, String postfix,
23 return new ExpressionMetadataBuilder(expression, postfix); 26 Builder parent, int charOffset) {
27 return new ExpressionMetadataBuilder(
28 expression, postfix, parent, charOffset);
24 } 29 }
25 } 30 }
26 31
27 class ConstructorMetadataBuilder<T extends TypeBuilder> 32 class ConstructorMetadataBuilder<T extends TypeBuilder>
28 extends MetadataBuilder<T> { 33 extends MetadataBuilder<T> {
29 final ConstructorReferenceBuilder constructorReference; 34 final ConstructorReferenceBuilder constructorReference;
30 35
31 final List arguments; 36 final List arguments;
32 37
33 ConstructorMetadataBuilder(this.constructorReference, this.arguments); 38 ConstructorMetadataBuilder(this.constructorReference, this.arguments,
39 Builder parent, int charOffset)
40 : super(parent, charOffset);
34 } 41 }
35 42
36 /// Expression metadata (without arguments). 43 /// Expression metadata (without arguments).
37 /// 44 ///
38 /// Matches this grammar rule: 45 /// Matches this grammar rule:
39 /// 46 ///
40 /// '@' qualified (‘.’ identifier)? 47 /// '@' qualified (‘.’ identifier)?
41 class ExpressionMetadataBuilder<T extends TypeBuilder> 48 class ExpressionMetadataBuilder<T extends TypeBuilder>
42 extends MetadataBuilder<T> { 49 extends MetadataBuilder<T> {
43 final String qualified; 50 final String qualified;
44 51
45 final String identifier; 52 final String identifier;
46 53
47 ExpressionMetadataBuilder(this.qualified, this.identifier); 54 ExpressionMetadataBuilder(this.qualified, this.identifier, Builder parent,
55 int charOffset)
56 : super(parent, charOffset);
48 } 57 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/member_builder.dart ('k') | pkg/front_end/lib/src/fasta/builder/mixed_accessor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698