Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
index b7ca156764bc47678dd467dc845466cca49fc7f3..025db2a7c9dd70f8739382936e7cb78032d99bb6 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
@@ -26,24 +26,24 @@ class KernelNamedTypeBuilder extends NamedTypeBuilder<KernelTypeBuilder>
implements KernelTypeBuilder {
TypeDeclarationBuilder<KernelTypeBuilder, DartType> builder;
- KernelNamedTypeBuilder(String name, List<KernelTypeBuilder> arguments)
- : super(name, arguments);
+ KernelNamedTypeBuilder(String name, List<KernelTypeBuilder> arguments,
+ int charOffset, Uri fileUri)
+ : super(name, arguments, charOffset, fileUri);
KernelInvalidTypeBuilder buildInvalidType(String name) {
- // TODO(ahe): Report error somewhere.
- print("Type not found: $name");
- return new KernelInvalidTypeBuilder(name, null);
+ // TODO(ahe): Record error instead of printing.
+ print("$fileUri:$charOffset: Type not found: $name");
+ return new KernelInvalidTypeBuilder(name, charOffset, fileUri);
}
DartType handleMissingType() {
- // TODO(ahe): Fix this.
- print("No type for: $name");
+ // TODO(ahe): Record error instead of printing.
+ print("$fileUri:$charOffset: No type for: $name");
return const DynamicType();
}
Supertype handleMissingSuperType() {
- // TODO(ahe): Fix this.
- return inputError(null, null, "No type for: $name");
+ throw inputError(fileUri, charOffset, "No type for: $name");
}
DartType build() {
@@ -83,7 +83,7 @@ class KernelNamedTypeBuilder extends NamedTypeBuilder<KernelTypeBuilder>
i++;
}
if (arguments != null) {
- return new KernelNamedTypeBuilder(name, arguments)
+ return new KernelNamedTypeBuilder(name, arguments, charOffset, fileUri)
..builder = builder;
}
}

Powered by Google App Engine
This is Rietveld 408576698