Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Side by Side Diff: pkg/front_end/test/subpackage_relationships_test.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/util/relativize.dart ('k') | pkg/kernel/lib/ast.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 7
8 import 'package:front_end/compiler_options.dart'; 8 import 'package:front_end/compiler_options.dart';
9 import 'package:front_end/dependency_grapher.dart'; 9 import 'package:front_end/dependency_grapher.dart';
10 import 'package:path/path.dart' as pathos; 10 import 'package:path/path.dart' as pathos;
(...skipping 21 matching lines...) Expand all
32 'lib/src/base': new SubpackageRules( 32 'lib/src/base': new SubpackageRules(
33 mayImportAnalyzer: true, allowedDependencies: ['lib']), 33 mayImportAnalyzer: true, allowedDependencies: ['lib']),
34 'lib/src/fasta': 34 'lib/src/fasta':
35 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [ 35 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [
36 'lib/src/fasta/builder', 36 'lib/src/fasta/builder',
37 'lib/src/fasta/dill', 37 'lib/src/fasta/dill',
38 'lib/src/fasta/kernel', 38 'lib/src/fasta/kernel',
39 'lib/src/fasta/parser', 39 'lib/src/fasta/parser',
40 'lib/src/fasta/scanner', 40 'lib/src/fasta/scanner',
41 'lib/src/fasta/testing', 41 'lib/src/fasta/testing',
42 'lib/src/fasta/util',
42 ]), 43 ]),
43 'lib/src/fasta/analyzer': 44 'lib/src/fasta/analyzer':
44 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [ 45 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [
45 'lib/src/fasta', 46 'lib/src/fasta',
46 'lib/src/fasta/builder', 47 'lib/src/fasta/builder',
47 'lib/src/fasta/dill', 48 'lib/src/fasta/dill',
48 'lib/src/fasta/kernel', 49 'lib/src/fasta/kernel',
49 'lib/src/fasta/scanner', 50 'lib/src/fasta/scanner',
50 'lib/src/fasta/source', 51 'lib/src/fasta/source',
51 ]), 52 ]),
(...skipping 10 matching lines...) Expand all
62 'lib/src/fasta', 63 'lib/src/fasta',
63 'lib/src/fasta/kernel', 64 'lib/src/fasta/kernel',
64 ]), 65 ]),
65 'lib/src/fasta/kernel': new SubpackageRules(allowedDependencies: [ 66 'lib/src/fasta/kernel': new SubpackageRules(allowedDependencies: [
66 'lib/src/fasta', 67 'lib/src/fasta',
67 'lib/src/fasta/builder', 68 'lib/src/fasta/builder',
68 'lib/src/fasta/dill', 69 'lib/src/fasta/dill',
69 'lib/src/fasta/parser', 70 'lib/src/fasta/parser',
70 'lib/src/fasta/scanner', 71 'lib/src/fasta/scanner',
71 'lib/src/fasta/source', 72 'lib/src/fasta/source',
73 'lib/src/fasta/util',
72 ]), 74 ]),
73 'lib/src/fasta/parser': 75 'lib/src/fasta/parser':
74 new SubpackageRules(allowSubdirs: true, allowedDependencies: [ 76 new SubpackageRules(allowSubdirs: true, allowedDependencies: [
75 'lib/src/fasta', 77 'lib/src/fasta',
76 'lib/src/fasta/scanner', 78 'lib/src/fasta/scanner',
77 'lib/src/fasta/util', 79 'lib/src/fasta/util',
78 ]), 80 ]),
79 'lib/src/fasta/scanner': 81 'lib/src/fasta/scanner':
80 new SubpackageRules(allowSubdirs: true, allowedDependencies: [ 82 new SubpackageRules(allowSubdirs: true, allowedDependencies: [
81 'lib/src/fasta', 83 'lib/src/fasta',
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 problem('Uri $src is inside package:front_end but is not in any known ' 229 problem('Uri $src is inside package:front_end but is not in any known '
228 'subpackage'); 230 'subpackage');
229 } else if (!subpackageRules[subpackage].allowSubdirs && 231 } else if (!subpackageRules[subpackage].allowSubdirs &&
230 pathWithinSubpackage.contains('/')) { 232 pathWithinSubpackage.contains('/')) {
231 problem('Uri $src is in a subfolder of $subpackage, but that ' 233 problem('Uri $src is in a subfolder of $subpackage, but that '
232 'subpackage does not allow dart files in subdirectories.'); 234 'subpackage does not allow dart files in subdirectories.');
233 } 235 }
234 return subpackage; 236 return subpackage;
235 } 237 }
236 } 238 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/util/relativize.dart ('k') | pkg/kernel/lib/ast.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698