Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: pkg/front_end/lib/src/fasta/builder/member_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.member_builder; 5 library fasta.member_builder;
6 6
7 import 'builder.dart' show 7 import 'builder.dart' show
8 Builder, 8 Builder,
9 ClassBuilder, 9 ClassBuilder,
10 ModifierBuilder; 10 ModifierBuilder;
11 11
12 abstract class MemberBuilder extends ModifierBuilder { 12 abstract class MemberBuilder extends ModifierBuilder {
13 /// For top-level members, the parent is set correctly during
14 /// construction. However, for class members, the parent is initially the
15 /// library and updated later.
13 Builder parent; 16 Builder parent;
14 17
18 MemberBuilder(Builder parent, int charOffset)
19 : parent = parent, super(parent, charOffset);
20
15 bool get isInstanceMember => isClassMember && !isStatic; 21 bool get isInstanceMember => isClassMember && !isStatic;
16 22
17 bool get isClassMember => parent is ClassBuilder; 23 bool get isClassMember => parent is ClassBuilder;
18 24
19 bool get isTopLevel => !isClassMember; 25 bool get isTopLevel => !isClassMember;
20 } 26 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/library_builder.dart ('k') | pkg/front_end/lib/src/fasta/builder/metadata_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698