Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index 3146fb1d99a093801080d39b1f8afe157f94d3e8..ef7f50f0839c15178815e6142f7bbd10bd9f319c 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -195,7 +195,10 @@ class KernelTarget extends TargetImplementation {
cls.implementedTypes.clear();
cls.supertype = null;
cls.mixedInType = null;
- builder.supertype = new KernelNamedTypeBuilder("Object", null)
+ builder.supertype =
+ new KernelNamedTypeBuilder(
+ "Object", null, builder.charOffset,
+ builder.fileUri ?? Uri.parse(cls.fileUri))
..builder = objectClassBuilder;
builder.interfaces = null;
}
@@ -277,7 +280,8 @@ class KernelTarget extends TargetImplementation {
// could also make sense to add a way to mark .dill files as having
// compile-time errors.
KernelProcedureBuilder mainBuilder = new KernelProcedureBuilder(null, 0,
- null, "main", null, null, AsyncMarker.Sync, ProcedureKind.Method);
+ null, "main", null, null, AsyncMarker.Sync, ProcedureKind.Method,
+ library, -1);
library.addBuilder(mainBuilder.name, mainBuilder);
mainBuilder.body = new ExpressionStatement(
new Throw(new StringLiteral("${errors.join('\n')}")));

Powered by Google App Engine
This is Rietveld 408576698