pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart - Issue 2691523002: Ensure locations are always provided, but don't store them yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)

Patch Set: Address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart

index fc49cb7ea45ae91dab4611a6b37749bb10a2ce8e..6b24840c8b32cf8dffd6849fe90ce0480902fe25 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart

@@ -9,14 +9,13 @@ import 'package:kernel/ast.dart' show

DynamicType;

import 'kernel_builder.dart' show

- Builder,

InvalidTypeBuilder,

KernelTypeBuilder;

class KernelInvalidTypeBuilder

extends InvalidTypeBuilder<KernelTypeBuilder, DartType> {

- KernelInvalidTypeBuilder(String name, Builder parent)

- : super(name, parent);

+ KernelInvalidTypeBuilder(String name, int charOffset, Uri fileUri)

+ : super(name, null, charOffset, fileUri);

DartType buildType(List<KernelTypeBuilder> arguments) {

// TODO(ahe): Implement error handling.