Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
index 8728eafb7ae48d744b59b6af3ff14f8f82f87887..5ac333a90abbeec6b79ec26b7c1f73e8a011b126 100644
--- a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
@@ -340,7 +340,7 @@ class SendAccessor extends IncompleteSend {
}
Expression result;
if (receiver is KernelClassBuilder) {
- Builder builder = receiver.findStaticBuilder(name.name);
+ Builder builder = receiver.findStaticBuilder(name.name, charOffset, uri);
if (builder == null) {
return buildThrowNoSuchMethodError(arguments);
}
@@ -422,11 +422,12 @@ class IncompletePropertyAccessor extends IncompleteSend {
prefix.exports[name.name], name.name, charOffset);
}
if (receiver is KernelClassBuilder) {
- Builder builder = receiver.findStaticBuilder(name.name);
+ Builder builder = receiver.findStaticBuilder(name.name, charOffset, uri);
Member getter = builder?.target;
Member setter;
if (builder == null) {
- builder = receiver.findStaticBuilder(name.name, isSetter: true);
+ builder = receiver.findStaticBuilder(
+ name.name, charOffset, uri, isSetter: true);
if (builder == null) {
return buildThrowNoSuchMethodError(null);
}
@@ -441,7 +442,8 @@ class IncompletePropertyAccessor extends IncompleteSend {
}
} else if (getter is Procedure) {
if (getter.isGetter) {
- builder = receiver.findStaticBuilder(name.name, isSetter: true);
+ builder = receiver.findStaticBuilder(
+ name.name, charOffset, uri, isSetter: true);
if (builder != null && !builder.hasProblem) {
setter = builder.target;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/body_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698