Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.kernel_class_builder; 5 library fasta.kernel_class_builder;
6 6
7 import 'package:kernel/ast.dart' show 7 import 'package:kernel/ast.dart' show
8 Class, 8 Class,
9 DartType, 9 DartType,
10 ExpressionStatement, 10 ExpressionStatement,
(...skipping 21 matching lines...) Expand all
32 import 'redirecting_factory_body.dart' show 32 import 'redirecting_factory_body.dart' show
33 RedirectingFactoryBody; 33 RedirectingFactoryBody;
34 34
35 abstract class KernelClassBuilder 35 abstract class KernelClassBuilder
36 extends ClassBuilder<KernelTypeBuilder, InterfaceType> { 36 extends ClassBuilder<KernelTypeBuilder, InterfaceType> {
37 KernelClassBuilder( 37 KernelClassBuilder(
38 List<MetadataBuilder> metadata, int modifiers, 38 List<MetadataBuilder> metadata, int modifiers,
39 String name, List<TypeVariableBuilder> typeVariables, 39 String name, List<TypeVariableBuilder> typeVariables,
40 KernelTypeBuilder supertype, List<KernelTypeBuilder> interfaces, 40 KernelTypeBuilder supertype, List<KernelTypeBuilder> interfaces,
41 Map<String, Builder> members, List<KernelTypeBuilder> types, 41 Map<String, Builder> members, List<KernelTypeBuilder> types,
42 LibraryBuilder parent) 42 LibraryBuilder parent, int charOffset)
43 : super(metadata, modifiers, name, typeVariables, supertype, interfaces, 43 : super(metadata, modifiers, name, typeVariables, supertype, interfaces,
44 members, types, parent); 44 members, types, parent, charOffset);
45 45
46 Class get cls; 46 Class get cls;
47 47
48 Class get target => cls; 48 Class get target => cls;
49 49
50 /// [arguments] have already been built. 50 /// [arguments] have already been built.
51 InterfaceType buildTypesWithBuiltArguments(List<DartType> arguments) { 51 InterfaceType buildTypesWithBuiltArguments(List<DartType> arguments) {
52 return arguments == null 52 return arguments == null
53 ? cls.rawType 53 ? cls.rawType
54 : new InterfaceType(cls, 54 : new InterfaceType(cls,
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 builder.body = new ExpressionStatement( 112 builder.body = new ExpressionStatement(
113 new Throw(new StringLiteral(message))); 113 new Throw(new StringLiteral(message)));
114 } 114 }
115 } 115 }
116 } 116 }
117 }); 117 });
118 } 118 }
119 return count; 119 return count;
120 } 120 }
121 } 121 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698