Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart

Issue 2691523002: Ensure locations are always provided, but don't store them yet. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart
index 61eed56e0aef2c04538922fcc7e084bb1dd9e444..34a3f8d68a4e1ddcb6dee86a108c5370b67e7acb 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart
@@ -13,14 +13,23 @@ import 'kernel_builder.dart' show
KernelTypeBuilder,
MixinApplicationBuilder;
+import '../util/relativize.dart' show
+ relativizeUri;
+
class KernelMixinApplicationBuilder
extends MixinApplicationBuilder<KernelTypeBuilder>
implements KernelTypeBuilder {
+ final int charOffset;
+
+ final String relativeFileUri;
+
Supertype builtType;
KernelMixinApplicationBuilder(KernelTypeBuilder supertype,
- List<KernelTypeBuilder> mixins)
- : super(supertype, mixins);
+ List<KernelTypeBuilder> mixins, int charOffset, Uri fileUri)
+ : charOffset = charOffset,
+ relativeFileUri = relativizeUri(fileUri),
+ super(supertype, mixins, charOffset, fileUri);
InterfaceType build() => buildSupertype().asInterfaceType;
@@ -41,7 +50,9 @@ class KernelMixinApplicationBuilder
isAbstract: true,
supertype: supertype,
mixedInType: mixin,
- typeParameters: null); // TODO(ahe): Compute these.
+ typeParameters: null, // TODO(ahe): Compute these.
+ fileUri: relativeFileUri);
+ application.fileOffset = charOffset;
// TODO(ahe): Use asThisSupertype instead and translate type variables.
supertype = application.asRawSupertype;
}

Powered by Google App Engine
This is Rietveld 408576698