Migrate WTF::HashMap::add() to ::insert()

Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2671933002
Cr-Commit-Position: refs/heads/master@{#448037}
Committed: https://chromium.googlesource.com/chromium/src/+/fb710b631287aea4df1536d05046e750184a7bda

[pilgrim_google, 2017-02-03 02:18:18]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[pilgrim_google, 2017-02-03 02:18:31]

Description was changed from

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-02-03 02:18:31]

Description was changed from

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pilgrim_google, 2017-02-03 02:18:40]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 02:19:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-03 03:47:13]

LGTM

https://codereview.chromium.org/2671933002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/HashMap.h (right):

https://codereview.chromium.org/2671933002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/HashMap.h:187: AddResult add(IncomingKeyType&&,
IncomingMappedType&&);

Shall we add a TODO that add() is deprecated?

[commit-bot: I haz the power, 2017-02-03 04:20:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 04:20:51]

Dry run: This issue passed the CQ dry run.

[pilgrim_google, 2017-02-03 13:18:52]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-02-03 13:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2671933002/#ps20001
(title: "rebase, add TODOs")

[commit-bot: I haz the power, 2017-02-03 13:19:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 13:29:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 13:29:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2017-02-03 18:48:29]

Description was changed from

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org
==========

[pilgrim_google, 2017-02-03 18:48:29]

pilgrim@chromium.org changed reviewers:
+ sky@chromium.org

[pilgrim_google, 2017-02-03 18:48:34]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 19:18:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486147714477520,
"parent_rev": "af83899ce3450b54d2d41159eb5a64fff8821fdf", "commit_rev":
"fb710b631287aea4df1536d05046e750184a7bda"}

[commit-bot: I haz the power, 2017-02-03 19:18:58]

Description was changed from

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org
==========

to

==========
Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2671933002
Cr-Commit-Position: refs/heads/master@{#448037}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb710b631287aea4df1536d05046...
==========

[commit-bot: I haz the power, 2017-02-03 19:19:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb710b631287aea4df1536d05046...

[sky, 2017-02-03 23:44:30]

mojo LGTM