Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)
Patch Set: rebase, add TODOs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 m_state.maxBandwidthMbps = maxBandwidthMbps; 84 m_state.maxBandwidthMbps = maxBandwidthMbps;
85 } 85 }
86 } 86 }
87 87
88 void NetworkStateNotifier::addObserver(NetworkStateObserver* observer, 88 void NetworkStateNotifier::addObserver(NetworkStateObserver* observer,
89 ExecutionContext* context) { 89 ExecutionContext* context) {
90 ASSERT(context->isContextThread()); 90 ASSERT(context->isContextThread());
91 ASSERT(observer); 91 ASSERT(observer);
92 92
93 MutexLocker locker(m_mutex); 93 MutexLocker locker(m_mutex);
94 ObserverListMap::AddResult result = m_observers.add(context, nullptr); 94 ObserverListMap::AddResult result = m_observers.insert(context, nullptr);
95 if (result.isNewEntry) 95 if (result.isNewEntry)
96 result.storedValue->value = WTF::wrapUnique(new ObserverList); 96 result.storedValue->value = WTF::wrapUnique(new ObserverList);
97 97
98 ASSERT(result.storedValue->value->observers.find(observer) == kNotFound); 98 ASSERT(result.storedValue->value->observers.find(observer) == kNotFound);
99 result.storedValue->value->observers.push_back(observer); 99 result.storedValue->value->observers.push_back(observer);
100 } 100 }
101 101
102 void NetworkStateNotifier::removeObserver(NetworkStateObserver* observer, 102 void NetworkStateNotifier::removeObserver(NetworkStateObserver* observer,
103 ExecutionContext* context) { 103 ExecutionContext* context) {
104 ASSERT(context->isContextThread()); 104 ASSERT(context->isContextThread());
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 203
204 list->zeroedObservers.clear(); 204 list->zeroedObservers.clear();
205 205
206 if (list->observers.isEmpty()) { 206 if (list->observers.isEmpty()) {
207 MutexLocker locker(m_mutex); 207 MutexLocker locker(m_mutex);
208 m_observers.erase(context); // deletes list 208 m_observers.erase(context); // deletes list
209 } 209 }
210 } 210 }
211 211
212 } // namespace blink 212 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698