third_party/WebKit/Source/core/layout/TextAutosizer.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/TextAutosizer.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/TextAutosizer.cpp

diff --git a/third_party/WebKit/Source/core/layout/TextAutosizer.cpp b/third_party/WebKit/Source/core/layout/TextAutosizer.cpp

index 6e082fd93d97a99aa597e837d833952fc895bf03..af61f4ee062355a2a97ee95ee8ea791af24cea91 100644

--- a/third_party/WebKit/Source/core/layout/TextAutosizer.cpp

+++ b/third_party/WebKit/Source/core/layout/TextAutosizer.cpp

@@ -886,7 +886,7 @@ TextAutosizer::FingerprintMapper::createSuperclusterIfNeeded(LayoutBlock* block,

return nullptr;

SuperclusterMap::AddResult addResult =

- m_superclusters.add(fingerprint, std::unique_ptr<Supercluster>());

+ m_superclusters.insert(fingerprint, std::unique_ptr<Supercluster>());

isNewEntry = addResult.isNewEntry;

if (!addResult.isNewEntry)

return addResult.storedValue->value.get();

@@ -1275,7 +1275,7 @@ void TextAutosizer::FingerprintMapper::addTentativeClusterRoot(

add(block, fingerprint);

ReverseFingerprintMap::AddResult addResult =

- m_blocksForFingerprint.add(fingerprint, std::unique_ptr<BlockSet>());

+ m_blocksForFingerprint.insert(fingerprint, std::unique_ptr<BlockSet>());

if (addResult.isNewEntry)

addResult.storedValue->value = WTF::wrapUnique(new BlockSet);

addResult.storedValue->value->insert(block);