third_party/WebKit/Source/core/dom/SpaceSplitString.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

diff --git a/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp b/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

index 79e529d523c51693b731efe58c430f9ec2ab7863..93fe3a8748f4e2569f82790f5ee3e081a1abc8ce 100644

--- a/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

+++ b/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp

@@ -167,7 +167,7 @@ SpaceSplitString::Data::~Data() {

PassRefPtr<SpaceSplitString::Data> SpaceSplitString::Data::create(

const AtomicString& string) {

- Data*& data = sharedDataMap().add(string, nullptr).storedValue->value;

+ Data*& data = sharedDataMap().insert(string, nullptr).storedValue->value;

if (!data) {

data = new Data(string);

return adoptRef(data);