third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp b/third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp

index b11a54e415859e83a374a1c0d384892f1fa0ea8d..e0bfc0e2bccd0fbcab15d743e6d17a6e5c96a488 100644

--- a/third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp

@@ -16,7 +16,7 @@ DEFINE_TRACE(GeolocationWatchers) {

bool GeolocationWatchers::add(int id, GeoNotifier* notifier) {

DCHECK_GT(id, 0);

- if (!m_idToNotifierMap.add(id, notifier).isNewEntry)

+ if (!m_idToNotifierMap.insert(id, notifier).isNewEntry)

return false;

m_notifierToIdMap.set(notifier, id);

return true;