third_party/WebKit/Source/core/dom/SelectorQuery.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SelectorQuery.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SelectorQuery.cpp

diff --git a/third_party/WebKit/Source/core/dom/SelectorQuery.cpp b/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

index fdbe3523554e87835fb5cfb4141fd75a3b25cc41..a2d571bc557b0dee8b2c84670245f481c609ec6c 100644

--- a/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

+++ b/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

@@ -639,7 +639,8 @@ SelectorQuery* SelectorQueryCache::add(const AtomicString& selectors,

if (m_entries.size() == maximumSelectorQueryCacheSize)

m_entries.remove(m_entries.begin());

- return m_entries.add(selectors, SelectorQuery::adopt(std::move(selectorList)))

+ return m_entries

+ .insert(selectors, SelectorQuery::adopt(std::move(selectorList)))

.storedValue->value.get();

}