Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/RequestTest.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)
Patch Set: rebase, add TODOs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/Request.h" 5 #include "modules/fetch/Request.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/V8BindingForTesting.h" 9 #include "bindings/core/v8/V8BindingForTesting.h"
10 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 EXPECT_EQ(url, request->url()); 77 EXPECT_EQ(url, request->url());
78 EXPECT_EQ(method, request->method()); 78 EXPECT_EQ(method, request->method());
79 EXPECT_EQ("audio", request->context()); 79 EXPECT_EQ("audio", request->context());
80 EXPECT_EQ(referrer, request->referrer()); 80 EXPECT_EQ(referrer, request->referrer());
81 EXPECT_EQ("navigate", request->mode()); 81 EXPECT_EQ("navigate", request->mode());
82 82
83 Headers* requestHeaders = request->getHeaders(); 83 Headers* requestHeaders = request->getHeaders();
84 84
85 WTF::HashMap<String, String> headersMap; 85 WTF::HashMap<String, String> headersMap;
86 for (int i = 0; headers[i].key; ++i) 86 for (int i = 0; headers[i].key; ++i)
87 headersMap.add(headers[i].key, headers[i].value); 87 headersMap.insert(headers[i].key, headers[i].value);
88 EXPECT_EQ(headersMap.size(), requestHeaders->headerList()->size()); 88 EXPECT_EQ(headersMap.size(), requestHeaders->headerList()->size());
89 for (WTF::HashMap<String, String>::iterator iter = headersMap.begin(); 89 for (WTF::HashMap<String, String>::iterator iter = headersMap.begin();
90 iter != headersMap.end(); ++iter) { 90 iter != headersMap.end(); ++iter) {
91 DummyExceptionStateForTesting exceptionState; 91 DummyExceptionStateForTesting exceptionState;
92 EXPECT_EQ(iter->value, requestHeaders->get(iter->key, exceptionState)); 92 EXPECT_EQ(iter->value, requestHeaders->get(iter->key, exceptionState));
93 EXPECT_FALSE(exceptionState.hadException()); 93 EXPECT_FALSE(exceptionState.hadException());
94 } 94 }
95 95
96 WebServiceWorkerRequest secondWebRequest; 96 WebServiceWorkerRequest secondWebRequest;
97 request->populateWebServiceWorkerRequest(secondWebRequest); 97 request->populateWebServiceWorkerRequest(secondWebRequest);
(...skipping 15 matching lines...) Expand all
113 Request::create(scope.getScriptState(), url, exceptionState); 113 Request::create(scope.getScriptState(), url, exceptionState);
114 ASSERT(request); 114 ASSERT(request);
115 115
116 WebServiceWorkerRequest webRequest; 116 WebServiceWorkerRequest webRequest;
117 request->populateWebServiceWorkerRequest(webRequest); 117 request->populateWebServiceWorkerRequest(webRequest);
118 EXPECT_EQ(urlWithoutFragment, KURL(webRequest.url())); 118 EXPECT_EQ(urlWithoutFragment, KURL(webRequest.url()));
119 } 119 }
120 120
121 } // namespace 121 } // namespace
122 } // namespace blink 122 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698