third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp ('k') | third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

index eb264fc86da8821833e6ec5ee7e3564d8899a17e..8c824b4bed2fb61c9e212174f10ba4ad66fe15f9 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

@@ -252,12 +252,12 @@ TEST_F(NotificationDataTest, DefaultTimestampValue) {

TEST_F(NotificationDataTest, DirectionValues) {

WTF::HashMap<String, WebNotificationData::Direction> mappings;

- mappings.add("ltr", WebNotificationData::DirectionLeftToRight);

- mappings.add("rtl", WebNotificationData::DirectionRightToLeft);

- mappings.add("auto", WebNotificationData::DirectionAuto);

+ mappings.insert("ltr", WebNotificationData::DirectionLeftToRight);

+ mappings.insert("rtl", WebNotificationData::DirectionRightToLeft);

+ mappings.insert("auto", WebNotificationData::DirectionAuto);

// Invalid values should default to "auto".

- mappings.add("peter", WebNotificationData::DirectionAuto);

+ mappings.insert("peter", WebNotificationData::DirectionAuto);

for (const String& direction : mappings.keys()) {

NotificationOptions options;