third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp ('k') | third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp b/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp

index 676c213eef5990c0723ef6470f5891d85f84cfb6..cec28d7dd8d94766b1b44c1469c58153c564e0db 100644

--- a/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp

@@ -86,7 +86,7 @@ void MatchedPropertiesCache::add(const ComputedStyle& style,

unsigned hash,

const MatchedPropertiesVector& properties) {

ASSERT(hash);

- Cache::AddResult addResult = m_cache.add(hash, nullptr);

+ Cache::AddResult addResult = m_cache.insert(hash, nullptr);

if (addResult.isNewEntry)

addResult.storedValue->value = new CachedMatchedProperties;