third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp b/third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp

index 2a7384bd11b18769e8f39e0db4b5bc42fc60b849..7a49e715ff731f66bbd50cc0d5143aa8d6032cfc 100644

--- a/third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp

+++ b/third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp

@@ -54,7 +54,7 @@ PassRefPtr<SimpleFontData> CSSFontFaceSource::getFontData(

FontCacheKey key = fontDescription.cacheKey(FontFaceCreationParams());

RefPtr<SimpleFontData>& fontData =

- m_fontDataTable.add(key, nullptr).storedValue->value;

+ m_fontDataTable.insert(key, nullptr).storedValue->value;

if (!fontData)

fontData = createFontData(fontDescription);

// No release, because fontData is a reference to a RefPtr that is held in the