third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/InputType.cpp ('k') | third_party/WebKit/Source/core/html/imports/HTMLImport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp b/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

index 0bf469de62bb93cc897b7be8b7948fbf02887670..354bbf7dd781eb30b1e165ac9c1857365eab2930 100644

--- a/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

@@ -95,7 +95,7 @@ void RadioButtonGroup::updateRequiredButton(MemberKeyValue& it,

void RadioButtonGroup::add(HTMLInputElement* button) {

DCHECK_EQ(button->type(), InputTypeNames::radio);

- auto addResult = m_members.add(button, false);

+ auto addResult = m_members.insert(button, false);

if (!addResult.isNewEntry)

return;

bool groupWasValid = isValid();

@@ -214,7 +214,8 @@ void RadioButtonGroupScope::addButton(HTMLInputElement* element) {

if (!m_nameToGroupMap)

m_nameToGroupMap = new NameToGroupMap;

- auto keyValue = m_nameToGroupMap->add(element->name(), nullptr).storedValue;

+ auto keyValue =

+ m_nameToGroupMap->insert(element->name(), nullptr).storedValue;

if (!keyValue->value)

keyValue->value = RadioButtonGroup::create();

keyValue->value->add(element);