third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp

diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp b/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp

index 32b8b166904655dfb8981ce960572199655bba76..87449dc182885516c1c1a16fcb3976cd98277933 100644

--- a/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp

+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp

@@ -110,7 +110,7 @@ static KeyValueMap retrieveKeyValuePairs(SharedBufferChunkReader* buffer) {

if (keyValuePairs.find(key) != keyValuePairs.end())

DVLOG(1) << "Key duplicate found in MIME header. Key is '" << key

<< "', previous value replaced.";

- keyValuePairs.add(key, value.toString().stripWhiteSpace());

+ keyValuePairs.insert(key, value.toString().stripWhiteSpace());

key = String();

value.clear();

}