third_party/WebKit/Source/core/html/HTMLCollection.h - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCollection.h

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLCollection.h

diff --git a/third_party/WebKit/Source/core/html/HTMLCollection.h b/third_party/WebKit/Source/core/html/HTMLCollection.h

index 3834d387c7df3f4d0333b1b762daa2ef7084dbd4..dd02557cd429bebc397d7aeaa04000dba395cb45 100644

--- a/third_party/WebKit/Source/core/html/HTMLCollection.h

+++ b/third_party/WebKit/Source/core/html/HTMLCollection.h

@@ -149,7 +149,7 @@ class CORE_EXPORT HTMLCollection

const AtomicString& key,

Element* element) {

Member<HeapVector<Member<Element>>>& vector =

- map.add(key.impl(), nullptr).storedValue->value;

+ map.insert(key.impl(), nullptr).storedValue->value;

if (!vector)

vector = new HeapVector<Member<Element>>;

vector->push_back(element);