third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

index b9a4a4b7437158db2ab17eb961a816741b8d2524..8ced2f1405db08de855e1b89ae0ec7354334c65f 100644

--- a/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp

@@ -102,7 +102,7 @@ PassRefPtr<FontData> CSSSegmentedFontFace::getFontData(

fontDescription.cacheKey(FontFaceCreationParams(), desiredTraits);

RefPtr<SegmentedFontData>& fontData =

- m_fontDataTable.add(key, nullptr).storedValue->value;

+ m_fontDataTable.insert(key, nullptr).storedValue->value;

if (fontData && fontData->numFaces()) {

// No release, we have a reference to an object in the cache which should

// retain the ref count it has.