third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp - Issue 2671933002: Migrate WTF::HashMap::add() to ::insert()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

Issue 2671933002: Migrate WTF::HashMap::add() to ::insert() (Closed)

Patch Set: rebase, add TODOs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

index 9f200f95cc7bc9b53884bf5c03928483be436c67..493d0005ece582cf8db132523fefcc2a8434b120 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

@@ -376,7 +376,7 @@ Response InspectorLayerTreeAgent::makeSnapshot(const String& layerId,

adoptRef(new PictureSnapshot(ToSkPicture(context.endRecording())));

*snapshotId = String::number(++s_lastSnapshotId);

- bool newEntry = m_snapshotById.add(*snapshotId, snapshot).isNewEntry;

+ bool newEntry = m_snapshotById.insert(*snapshotId, snapshot).isNewEntry;

DCHECK(newEntry);

return Response::OK();

}

@@ -402,7 +402,7 @@ Response InspectorLayerTreeAgent::loadSnapshot(

return Response::Error("Empty snapshot");

*snapshotId = String::number(++s_lastSnapshotId);

- bool newEntry = m_snapshotById.add(*snapshotId, snapshot).isNewEntry;

+ bool newEntry = m_snapshotById.insert(*snapshotId, snapshot).isNewEntry;

DCHECK(newEntry);

return Response::OK();

}