Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, shans, webcomponents-bugzilla_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, nessy, pdr, loislo+blink_chromium.org, Steve Block, dino_apple.com, Nils Barth (inactive), blink-layers+watch_chromium.org, caseq+blink_chromium.org, Nate Chapin, aboxhall, marja+watch_chromium.org, dglazkov+blink, abarth-chromium, aandrey+blink_chromium.org, dstockwell, Timothy Loh, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, Eric Willigers, kenneth.christiansen, alancutter (OOO until 2018), rjwright, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, feature-media-reviews_chromium.org, dmazzoni, darktears, haraken, kojih, vcarbune.chromium, gavinp+prerender_chromium.org, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), paulirish+reviews_chromium.org, f(malita), groby+blinkspell_chromium.org, chromiumbugtracker_adobe.com, Stephen Chennney, jeez
Visibility:
Public.

Description

Have Node::document() return a reference instead of a pointer Have Node::document() return a reference instead of a pointer now that the method can no longer return NULL. DocumentType Nodes have been recently updated so that they always have an associated document (as per DOM4). R=abarth@chromium.org BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157019 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157023

Patch Set 1 #

Patch Set 2 : Fix build issues #

Patch Set 3 : Windows build fix #

Patch Set 4 : Rebase on master #

Patch Set 5 : Build fix for Android #

Patch Set 6 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1917 lines, -1969 lines) Patch
M Source/bindings/v8/BindingSecurity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptEventListener.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8GCController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/accessibility/AccessibilityARIAGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityImageMapLink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityListBoxOption.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AccessibilityMenuList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AccessibilityNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 13 chunks +24 lines, -32 lines 0 comments Download
M Source/core/accessibility/AccessibilitySlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCanvasValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 16 chunks +28 lines, -27 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/SVGCSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 11 chunks +16 lines, -16 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementResolveContext.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/resolver/ElementResolveContext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/CDATASection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CharacterData.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/ChildListMutationScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClassNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Comment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 18 chunks +26 lines, -26 lines 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/CustomElementCallbackInvocation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CustomElementRegistrationContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 15 chunks +18 lines, -18 lines 0 comments Download
M Source/core/dom/DocumentEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentFragment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentType.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 79 chunks +134 lines, -134 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventDispatcher.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/EventPathWalker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventRetargeter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventTarget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MouseRelatedEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/dom/Node.cpp View 38 chunks +66 lines, -67 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/dom/NodeRenderingContext.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 8 chunks +16 lines, -16 lines 0 comments Download
M Source/core/dom/PseudoElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.cpp View 18 chunks +22 lines, -22 lines 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 10 chunks +16 lines, -16 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/StyleElement.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/Text.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/AppendNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/Caret.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/Editor.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MoveSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RemoveNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RemoveNodePreservingChildrenCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SetSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellingCorrectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SplitTextNodeCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/SplitTextNodeContainingElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextCheckingHelper.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/markup.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/BaseButtonInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/BaseChooserOnlyDateAndTimeInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 5 chunks +8 lines, -9 lines 0 comments Download
M Source/core/html/ClassList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ColorInputType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/FileInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 9 chunks +20 lines, -22 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBaseElement.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 6 chunks +48 lines, -48 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLFormControlElementWithState.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 15 chunks +23 lines, -23 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 2 chunks +17 lines, -17 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 3 4 17 chunks +30 lines, -30 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 15 chunks +25 lines, -25 lines 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 13 chunks +21 lines, -21 lines 0 comments Download
M Source/core/html/HTMLMetaElement.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLParamElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 9 chunks +23 lines, -24 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLStyleElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 10 chunks +16 lines, -16 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLTablePartElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTemplateElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 15 chunks +17 lines, -17 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/ImageDocument.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/ImageInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/InputType.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/LinkImport.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/LinkResource.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/PasswordInputType.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/RadioInputType.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/RangeInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TextFieldInputType.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/ValidationMessage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 10 chunks +12 lines, -20 lines 0 comments Download
M Source/core/html/ime/InputMethodContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/ClearButtonElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 15 chunks +20 lines, -20 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/HTMLContentElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/HTMLShadowElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControlsChromium.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/PasswordGeneratorButtonElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/WebVTTElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 7 chunks +13 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FormSubmission.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 8 chunks +19 lines, -19 lines 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ContextMenuController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/DOMSelection.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/DragController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M Source/core/page/FocusController.cpp View 6 chunks +8 lines, -9 lines 0 comments Download
M Source/core/page/Frame.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/page/FrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PointerLockController.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/page/PrintContext.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/SpatialNavigation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/TouchAdjustment.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/TouchDisambiguation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/animation/AnimationController.cpp View 4 chunks +3 lines, -6 lines 0 comments Download
M Source/core/page/animation/ImplicitAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/animation/KeyframeAnimation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/Pasteboard.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/AutoTableLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/FlowThreadController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 14 chunks +17 lines, -17 lines 0 comments Download
M Source/core/rendering/ImageQualityController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBR.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 3 4 24 chunks +29 lines, -29 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 10 chunks +18 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 23 chunks +28 lines, -30 lines 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMarquee.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 5 chunks +6 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 17 chunks +27 lines, -27 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderQuote.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRuby.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRubyRun.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderScrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/SubtreeLayoutScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/ReferenceFilterBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTextPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineFlowBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 9 chunks +12 lines, -13 lines 0 comments Download
M Source/core/rendering/svg/SVGResourcesCache.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/scripts/make_names.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 10 chunks +13 lines, -15 lines 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.cpp View 5 chunks +9 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 3 chunks +7 lines, -8 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGlyphRefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLocatable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 13 chunks +21 lines, -21 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyleElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyleElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTRefElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 7 chunks +10 lines, -11 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTitleElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 9 chunks +15 lines, -17 lines 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGZoomAndPan.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 2 3 4 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 14 chunks +15 lines, -15 lines 0 comments Download
M Source/core/xml/XPathExpression.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathNodeSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathStep.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLStyleSheetLibxslt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/web/AutofillPopupMenuClient.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FullscreenController.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebNode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPasswordFormData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 13 chunks +17 lines, -17 lines 0 comments Download
M Source/web/WebSearchableFormData.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 3 months ago (2013-08-30 18:40:06 UTC) #1
abarth-chromium
I sampled a random subset of these changes, and LGTM
7 years, 3 months ago (2013-08-30 19:49:02 UTC) #2
do-not-use
Committed patchset #4 manually as r157019 (presubmit successful).
7 years, 3 months ago (2013-08-30 20:52:44 UTC) #3
do-not-use
7 years, 3 months ago (2013-08-30 22:34:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r157023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698