Source/core/rendering/svg/ReferenceFilterBuilder.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/ReferenceFilterBuilder.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/ReferenceFilterBuilder.cpp

diff --git a/Source/core/rendering/svg/ReferenceFilterBuilder.cpp b/Source/core/rendering/svg/ReferenceFilterBuilder.cpp

index b2a9feb84f38ace7759b2e534922d9664c182650..e9c656c19acbdd4f3552af1bc61f6bb07020ef08 100644

--- a/Source/core/rendering/svg/ReferenceFilterBuilder.cpp

+++ b/Source/core/rendering/svg/ReferenceFilterBuilder.cpp

@@ -89,8 +89,7 @@ PassRefPtr<FilterEffect> ReferenceFilterBuilder::build(Filter* parentFilter, Ren

if (!renderer)

return 0;

- Document* document = renderer->document();

- ASSERT(document);

+ Document* document = &renderer->document();

DocumentResourceReference* documentResourceReference = filterOperation->documentResourceReference();

DocumentResource* cachedSVGDocument = documentResourceReference ? documentResourceReference->document() : 0;