Source/core/svg/SVGGlyphRefElement.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGlyphRefElement.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGGlyphRefElement.cpp

diff --git a/Source/core/svg/SVGGlyphRefElement.cpp b/Source/core/svg/SVGGlyphRefElement.cpp

index 4594e318d29cad4fd98e5d3f8cc8da5bd1da2c00..618d0c9059c19aa73fb4e9cc2705e1c98c6f885f 100644

--- a/Source/core/svg/SVGGlyphRefElement.cpp

+++ b/Source/core/svg/SVGGlyphRefElement.cpp

@@ -58,7 +58,7 @@ bool SVGGlyphRefElement::hasValidGlyphElement(String& glyphName) const

{

// FIXME: We only support xlink:href so far.

// https://bugs.webkit.org/show_bug.cgi?id=64787

- Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefAttr), document(), &glyphName);

+ Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefAttr), &document(), &glyphName);

if (!element || !element->hasTagName(SVGNames::glyphTag))

return false;

return true;

« no previous file with comments | « Source/core/svg/SVGFontFaceUriElement.cpp ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »