Source/core/xml/XPathNodeSet.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathNodeSet.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/XPathNodeSet.cpp

diff --git a/Source/core/xml/XPathNodeSet.cpp b/Source/core/xml/XPathNodeSet.cpp

index 1f64ad03503e679ba4a03b0fbad0215f6073ffcd..c6219947ab493e31da3ba8fc52ec1663d15575ea 100644

--- a/Source/core/xml/XPathNodeSet.cpp

+++ b/Source/core/xml/XPathNodeSet.cpp

@@ -182,7 +182,7 @@ static Node* findRootNode(Node* node)

if (node->isAttributeNode())

node = toAttr(node)->ownerElement();

if (node->inDocument())

- node = node->document();

+ node = &node->document();

else {

while (Node* parent = node->parentNode())

node = parent;

« no previous file with comments | « Source/core/xml/XPathExpression.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »