Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: Source/bindings/v8/ScriptEventListener.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/BindingSecurity.cpp ('k') | Source/bindings/v8/V8GCController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 PassRefPtr<V8LazyEventListener> createAttributeEventListener(Node* node, const Q ualifiedName& name, const AtomicString& value) 53 PassRefPtr<V8LazyEventListener> createAttributeEventListener(Node* node, const Q ualifiedName& name, const AtomicString& value)
54 { 54 {
55 ASSERT(node); 55 ASSERT(node);
56 if (value.isNull()) 56 if (value.isNull())
57 return 0; 57 return 0;
58 58
59 // FIXME: Very strange: we initialize zero-based number with '1'. 59 // FIXME: Very strange: we initialize zero-based number with '1'.
60 TextPosition position(OrdinalNumber::fromZeroBasedInt(1), OrdinalNumber::fir st()); 60 TextPosition position(OrdinalNumber::fromZeroBasedInt(1), OrdinalNumber::fir st());
61 String sourceURL; 61 String sourceURL;
62 62
63 if (Frame* frame = node->document()->frame()) { 63 if (Frame* frame = node->document().frame()) {
64 ScriptController* scriptController = frame->script(); 64 ScriptController* scriptController = frame->script();
65 if (!scriptController->canExecuteScripts(AboutToExecuteScript)) 65 if (!scriptController->canExecuteScripts(AboutToExecuteScript))
66 return 0; 66 return 0;
67 position = scriptController->eventHandlerPosition(); 67 position = scriptController->eventHandlerPosition();
68 sourceURL = node->document()->url().string(); 68 sourceURL = node->document().url().string();
69 } 69 }
70 70
71 return V8LazyEventListener::create(name.localName().string(), eventParameter Name(node->isSVGElement()), value, sourceURL, position, node); 71 return V8LazyEventListener::create(name.localName().string(), eventParameter Name(node->isSVGElement()), value, sourceURL, position, node);
72 } 72 }
73 73
74 PassRefPtr<V8LazyEventListener> createAttributeEventListener(Frame* frame, const QualifiedName& name, const AtomicString& value) 74 PassRefPtr<V8LazyEventListener> createAttributeEventListener(Frame* frame, const QualifiedName& name, const AtomicString& value)
75 { 75 {
76 if (!frame) 76 if (!frame)
77 return 0; 77 return 0;
78 78
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 v8::ScriptOrigin origin = function->GetScriptOrigin(); 149 v8::ScriptOrigin origin = function->GetScriptOrigin();
150 if (origin.ResourceName()->IsString() && !origin.ResourceName().IsEmpty()) 150 if (origin.ResourceName()->IsString() && !origin.ResourceName().IsEmpty())
151 sourceName = toWebCoreString(origin.ResourceName()); 151 sourceName = toWebCoreString(origin.ResourceName());
152 else 152 else
153 sourceName = ""; 153 sourceName = "";
154 lineNumber = function->GetScriptLineNumber(); 154 lineNumber = function->GetScriptLineNumber();
155 return true; 155 return true;
156 } 156 }
157 157
158 } // namespace WebCore 158 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/BindingSecurity.cpp ('k') | Source/bindings/v8/V8GCController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698