Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: Source/core/svg/SVGFEConvolveMatrixElement.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElementRareData.h ('k') | Source/core/svg/SVGFEImageElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFEConvolveMatrixElement.cpp
diff --git a/Source/core/svg/SVGFEConvolveMatrixElement.cpp b/Source/core/svg/SVGFEConvolveMatrixElement.cpp
index 59cb12f816679c8c970b149a7ffedc473bae4e16..d6be4b744d8af3053e98c25aaa6af36b106eb6b0 100644
--- a/Source/core/svg/SVGFEConvolveMatrixElement.cpp
+++ b/Source/core/svg/SVGFEConvolveMatrixElement.cpp
@@ -135,10 +135,11 @@ void SVGFEConvolveMatrixElement::parseAttribute(const QualifiedName& name, const
if (parseNumberOptionalNumber(value, x, y) && x >= 1 && y >= 1) {
setOrderXBaseValue(x);
setOrderYBaseValue(y);
- } else
- document()->accessSVGExtensions()->reportWarning(
+ } else {
+ document().accessSVGExtensions()->reportWarning(
"feConvolveMatrix: problem parsing order=\"" + value
+ "\". Filtered element will not be displayed.");
+ }
return;
}
@@ -147,7 +148,7 @@ void SVGFEConvolveMatrixElement::parseAttribute(const QualifiedName& name, const
if (propertyValue > 0)
setEdgeModeBaseValue(propertyValue);
else
- document()->accessSVGExtensions()->reportWarning(
+ document().accessSVGExtensions()->reportWarning(
"feConvolveMatrix: problem parsing edgeMode=\"" + value
+ "\". Filtered element will not be displayed.");
return;
@@ -166,7 +167,7 @@ void SVGFEConvolveMatrixElement::parseAttribute(const QualifiedName& name, const
if (divisor)
setDivisorBaseValue(divisor);
else
- document()->accessSVGExtensions()->reportWarning(
+ document().accessSVGExtensions()->reportWarning(
"feConvolveMatrix: problem parsing divisor=\"" + value
+ "\". Filtered element will not be displayed.");
return;
@@ -192,10 +193,11 @@ void SVGFEConvolveMatrixElement::parseAttribute(const QualifiedName& name, const
if (parseNumberOptionalNumber(value, x, y) && x > 0 && y > 0) {
setKernelUnitLengthXBaseValue(x);
setKernelUnitLengthYBaseValue(y);
- } else
- document()->accessSVGExtensions()->reportWarning(
+ } else {
+ document().accessSVGExtensions()->reportWarning(
"feConvolveMatrix: problem parsing kernelUnitLength=\"" + value
+ "\". Filtered element will not be displayed.");
+ }
return;
}
@@ -205,7 +207,7 @@ void SVGFEConvolveMatrixElement::parseAttribute(const QualifiedName& name, const
else if (value == "false")
setPreserveAlphaBaseValue(false);
else
- document()->accessSVGExtensions()->reportWarning(
+ document().accessSVGExtensions()->reportWarning(
"feConvolveMatrix: problem parsing preserveAlphaAttr=\"" + value
+ "\". Filtered element will not be displayed.");
return;
« no previous file with comments | « Source/core/svg/SVGElementRareData.h ('k') | Source/core/svg/SVGFEImageElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698