Have Node::document() return a reference instead of a pointer

Source/core/dom/CharacterData.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 37 matching lines @@
 {
     const String& nonNullData = !data.isNull() ? data : emptyString();
     if (m_data == nonNullData)
         return;
 
     RefPtr<CharacterData> protect = this;
 
     unsigned oldLength = length();
 
     setDataAndUpdate(nonNullData, 0, oldLength, nonNullData.length());
-    document()->textRemoved(this, 0, oldLength);
+    document().textRemoved(this, 0, oldLength);
 }
 
 String CharacterData::substringData(unsigned offset, unsigned count, ExceptionState& es)
 {
     if (offset > length()) {
         es.throwDOMException(IndexSizeError);
         return String();
     }
 
     return m_data.substring(offset, count);
@@ skipping 24 matching lines @@
 
     if (string.is8Bit())
         m_data.append(string.characters8() + offset, characterLengthLimit);
     else
         m_data.append(string.characters16() + offset, characterLengthLimit);
 
     ASSERT(!renderer() || isTextNode());
     if (isTextNode())
         toText(this)->updateTextRenderer(oldLength, 0, DeprecatedAttachNow);
 
-    document()->incDOMTreeVersion();
+    document().incDOMTreeVersion();
 
     if (parentNode())
         parentNode()->childrenChanged();
 
     return characterLengthLimit;
 }
 
 void CharacterData::appendData(const String& data, AttachBehavior attachBehavior)
 {
     String newStr = m_data + data;
 
     setDataAndUpdate(newStr, m_data.length(), 0, data.length(), attachBehavior);
 
     // FIXME: Should we call textInserted here?
 }
 
 void CharacterData::insertData(unsigned offset, const String& data, ExceptionState& es, AttachBehavior attachBehavior)
 {
     if (offset > length()) {
         es.throwDOMException(IndexSizeError);
         return;
     }
 
     String newStr = m_data;
     newStr.insert(data, offset);
 
     setDataAndUpdate(newStr, offset, 0, data.length(), attachBehavior);
 
-    document()->textInserted(this, offset, data.length());
+    document().textInserted(this, offset, data.length());
 }
 
 void CharacterData::deleteData(unsigned offset, unsigned count, ExceptionState& es, AttachBehavior attachBehavior)
 {
     if (offset > length()) {
         es.throwDOMException(IndexSizeError);
         return;
     }
 
     unsigned realCount;
     if (offset + count > length())
         realCount = length() - offset;
     else
         realCount = count;
 
     String newStr = m_data;
     newStr.remove(offset, realCount);
 
     setDataAndUpdate(newStr, offset, count, 0, attachBehavior);
 
-    document()->textRemoved(this, offset, realCount);
+    document().textRemoved(this, offset, realCount);
 }
 
 void CharacterData::replaceData(unsigned offset, unsigned count, const String& data, ExceptionState& es, AttachBehavior attachBehavior)
 {
     if (offset > length()) {
         es.throwDOMException(IndexSizeError);
         return;
     }
 
     unsigned realCount;
     if (offset + count > length())
         realCount = length() - offset;
     else
         realCount = count;
 
     String newStr = m_data;
     newStr.remove(offset, realCount);
     newStr.insert(data, offset);
 
     setDataAndUpdate(newStr, offset, count, data.length(), attachBehavior);
 
     // update the markers for spell checking and grammar checking
-    document()->textRemoved(this, offset, realCount);
-    document()->textInserted(this, offset, data.length());
+    document().textRemoved(this, offset, realCount);
+    document().textInserted(this, offset, data.length());
 }
 
 String CharacterData::nodeValue() const
 {
     return m_data;
 }
 
 bool CharacterData::containsOnlyWhitespace() const
 {
     return m_data.containsOnlyWhitespace();
 }
 
 void CharacterData::setNodeValue(const String& nodeValue)
 {
     setData(nodeValue);
 }
 
 void CharacterData::setDataAndUpdate(const String& newData, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, AttachBehavior attachBehavior)
 {
     String oldData = m_data;
     m_data = newData;
 
     ASSERT(!renderer() || isTextNode());
     if (isTextNode())
         toText(this)->updateTextRenderer(offsetOfReplacedData, oldLength, attachBehavior);
 
     if (nodeType() == PROCESSING_INSTRUCTION_NODE)
         toProcessingInstruction(this)->checkStyleSheet();
 
-    if (document()->frame())
-        document()->frame()->selection()->textWasReplaced(this, offsetOfReplacedData, oldLength, newLength);
+    if (document().frame())
+        document().frame()->selection()->textWasReplaced(this, offsetOfReplacedData, oldLength, newLength);
 
-    document()->incDOMTreeVersion();
+    document().incDOMTreeVersion();
     didModifyData(oldData);
 }
 
 void CharacterData::didModifyData(const String& oldData)
 {
     if (OwnPtr<MutationObserverInterestGroup> mutationRecipients = MutationObserverInterestGroup::createForCharacterDataMutation(this))
         mutationRecipients->enqueueMutationRecord(MutationRecord::createCharacterData(this, oldData));
 
     if (parentNode())
         parentNode()->childrenChanged();
 
     if (!isInShadowTree()) {
-        if (document()->hasListenerType(Document::DOMCHARACTERDATAMODIFIED_LISTENER))
+        if (document().hasListenerType(Document::DOMCHARACTERDATAMODIFIED_LISTENER))
             dispatchScopedEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, 0, oldData, m_data));
         dispatchSubtreeModifiedEvent();
     }
-    InspectorInstrumentation::characterDataModified(document(), this);
+    InspectorInstrumentation::characterDataModified(&document(), this);
 }
 
 int CharacterData::maxCharacterOffset() const
 {
     return static_cast<int>(length());
 }
 
 bool CharacterData::offsetInCharacters() const
 {
     return true;
 }
 
 } // namespace WebCore