Source/bindings/v8/V8GCController.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8GCController.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8GCController.cpp

diff --git a/Source/bindings/v8/V8GCController.cpp b/Source/bindings/v8/V8GCController.cpp

index 98c755bbfc4fa7d17b8034919fdeb2bee2dad39d..ab880d8dc85fea7a04dbe2adc76ce4d1cb0a6214 100644

--- a/Source/bindings/v8/V8GCController.cpp

+++ b/Source/bindings/v8/V8GCController.cpp

@@ -75,7 +75,7 @@ Node* V8GCController::opaqueRootForGC(Node* node, v8::Isolate*)

// Maybe should image elements be active DOM nodes?

// See https://code.google.com/p/chromium/issues/detail?id=164882

if (node->inDocument() || (node->hasTagName(HTMLNames::imgTag) && toHTMLImageElement(node)->hasPendingActivity()))

- return node->document();

+ return &node->document();

if (node->isAttributeNode()) {

Node* ownerElement = toAttr(node)->ownerElement();