Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: Source/core/html/HTMLKeygenElement.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLLabelElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLKeygenElement.cpp
diff --git a/Source/core/html/HTMLKeygenElement.cpp b/Source/core/html/HTMLKeygenElement.cpp
index 18e149460a573a60647dfdba7315ccaf4ce146f4..e804d074d11e4672faf2c65a5e17f98ded345ef1 100644
--- a/Source/core/html/HTMLKeygenElement.cpp
+++ b/Source/core/html/HTMLKeygenElement.cpp
@@ -58,11 +58,11 @@ void HTMLKeygenElement::didAddUserAgentShadowRoot(ShadowRoot* root)
getSupportedKeySizes(keys);
// Create a select element with one option element for each key size.
- RefPtr<HTMLSelectElement> select = HTMLSelectElement::create(document());
+ RefPtr<HTMLSelectElement> select = HTMLSelectElement::create(&document());
select->setPart(keygenSelectPseudoId);
for (size_t i = 0; i < keys.size(); ++i) {
- RefPtr<HTMLOptionElement> option = HTMLOptionElement::create(document());
- option->appendChild(Text::create(document(), keys[i]));
+ RefPtr<HTMLOptionElement> option = HTMLOptionElement::create(&document());
+ option->appendChild(Text::create(&document(), keys[i]));
select->appendChild(option);
}
@@ -84,7 +84,7 @@ bool HTMLKeygenElement::appendFormData(FormDataList& encoding, bool)
const AtomicString& keyType = fastGetAttribute(keytypeAttr);
if (!keyType.isNull() && !equalIgnoringCase(keyType, "rsa"))
return false;
- String value = signedPublicKeyAndChallengeString(shadowSelect()->selectedIndex(), fastGetAttribute(challengeAttr), document()->baseURL());
+ String value = signedPublicKeyAndChallengeString(shadowSelect()->selectedIndex(), fastGetAttribute(challengeAttr), document().baseURL());
if (value.isNull())
return false;
encoding.appendData(name(), value.utf8());
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLLabelElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698