Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 } 108 }
109 for (size_t i = 0; i < toRemove.size(); ++i) 109 for (size_t i = 0; i < toRemove.size(); ++i)
110 m_cache.remove(toRemove[i]); 110 m_cache.remove(toRemove[i]);
111 111
112 m_additionsSinceLastSweep = 0; 112 m_additionsSinceLastSweep = 0;
113 } 113 }
114 114
115 bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty le* style, const RenderStyle* parentStyle) 115 bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderSty le* style, const RenderStyle* parentStyle)
116 { 116 {
117 // FIXME: CSSPropertyWebkitWritingMode modifies state when applying to docum ent element. We can't skip the applying by caching. 117 // FIXME: CSSPropertyWebkitWritingMode modifies state when applying to docum ent element. We can't skip the applying by caching.
118 if (element == element->document()->documentElement() && element->document() ->writingModeSetOnDocumentElement()) 118 if (element == element->document().documentElement() && element->document(). writingModeSetOnDocumentElement())
119 return false; 119 return false;
120 if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->uniqu e())) 120 if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->uniqu e()))
121 return false; 121 return false;
122 if (style->hasAppearance()) 122 if (style->hasAppearance())
123 return false; 123 return false;
124 if (style->zoom() != RenderStyle::initialZoom()) 124 if (style->zoom() != RenderStyle::initialZoom())
125 return false; 125 return false;
126 if (style->writingMode() != RenderStyle::initialWritingMode()) 126 if (style->writingMode() != RenderStyle::initialWritingMode())
127 return false; 127 return false;
128 // The cache assumes static knowledge about which properties are inherited. 128 // The cache assumes static knowledge about which properties are inherited.
129 if (parentStyle->hasExplicitlyInheritedProperties()) 129 if (parentStyle->hasExplicitlyInheritedProperties())
130 return false; 130 return false;
131 return true; 131 return true;
132 } 132 }
133 133
134 } 134 }
OLDNEW
« no previous file with comments | « Source/core/css/resolver/ElementResolveContext.cpp ('k') | Source/core/css/resolver/ScopedStyleResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698