Source/core/dom/CustomElementRegistrationContext.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/CustomElementRegistrationContext.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/dom/CustomElementCallbackInvocation.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 128 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
139 // 2. Undoing a command (eg ReplaceNodeWithSpan) recycles an	139 // 2. Undoing a command (eg ReplaceNodeWithSpan) recycles an

140 // element but tries to overwrite its attribute list.	140 // element but tries to overwrite its attribute list.

141 return;	141 return;

142 }	142 }

143	143

144 // Custom tags take precedence over type extensions	144 // Custom tags take precedence over type extensions

145 ASSERT(!CustomElement::isValidName(element->localName()));	145 ASSERT(!CustomElement::isValidName(element->localName()));

146	146

147 element->setCustomElementState(mode == CreatedByParser ? Element::WaitingFor Parser : Element::WaitingForUpgrade);	147 element->setCustomElementState(mode == CreatedByParser ? Element::WaitingFor Parser : Element::WaitingForUpgrade);

148	148

149 if (CustomElementRegistrationContext* context = element->document()->registr ationContext())	149 if (CustomElementRegistrationContext* context = element->document().registra tionContext())

150 context->didGiveTypeExtension(element, type);	150 context->didGiveTypeExtension(element, type);

151 }	151 }

152	152

153 } // namespace WebCore	153 } // namespace WebCore

OLD	NEW