Source/core/svg/SVGLinearGradientElement.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGLinearGradientElement.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGLinearGradientElement.cpp

diff --git a/Source/core/svg/SVGLinearGradientElement.cpp b/Source/core/svg/SVGLinearGradientElement.cpp

index 5d5a8076cc303e27dd84fbe769d35f0283995257..ec179a385526916dca8f71c8fa2d61ca6eb72ba9 100644

--- a/Source/core/svg/SVGLinearGradientElement.cpp

+++ b/Source/core/svg/SVGLinearGradientElement.cpp

@@ -166,7 +166,7 @@ bool SVGLinearGradientElement::collectGradientAttributes(LinearGradientAttribute

processedGradients.add(current);

// Respect xlink:href, take attributes from referenced element

- Node* refNode = SVGURIReference::targetElementFromIRIString(current->hrefCurrentValue(), document());

+ Node* refNode = SVGURIReference::targetElementFromIRIString(current->hrefCurrentValue(), &document());

if (refNode && (refNode->hasTagName(SVGNames::linearGradientTag) || refNode->hasTagName(SVGNames::radialGradientTag))) {

current = toSVGGradientElement(refNode);

« no previous file with comments | « Source/core/svg/SVGLengthContext.cpp ('k') | Source/core/svg/SVGLocatable.cpp » ('j') | no next file with comments »