Have Node::document() return a reference instead of a pointer

Source/core/html/HTMLObjectElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 183 matching lines @@
         }
     }
 
     mapDataParamToSrc(&paramNames, &paramValues);
 
     // HTML5 says that an object resource's URL is specified by the object's data
     // attribute, not by a param element. However, for compatibility, allow the
     // resource's URL to be given by a param named "src", "movie", "code" or "url"
     // if we know that resource points to a plug-in.
     if (url.isEmpty() && !urlParameter.isEmpty()) {
-        KURL completedURL = document()->completeURL(urlParameter);
+        KURL completedURL = document().completeURL(urlParameter);
         bool useFallback;
         if (shouldUsePlugin(completedURL, serviceType, false, useFallback))
             url = urlParameter;
     }
 }
 
 
 bool HTMLObjectElement::hasFallbackContent() const
 {
     for (Node* child = firstChild(); child; child = child->nextSibling()) {
         // Ignore whitespace-only text, and <param> tags, any other content is fallback content.
         if (child->isTextNode()) {
             if (!toText(child)->containsOnlyWhitespace())
                 return true;
         } else if (!child->hasTagName(paramTag))
             return true;
     }
     return false;
 }
 
 bool HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk()
 {
     // This site-specific hack maintains compatibility with Mac OS X Wiki Server,
     // which embeds QuickTime movies using an object tag containing QuickTime's
     // ActiveX classid. Treat this classid as valid only if OS X Server's unique
     // 'generator' meta tag is present. Only apply this quirk if there is no
     // fallback content, which ensures the quirk will disable itself if Wiki
     // Server is updated to generate an alternate embed tag as fallback content.
-    if (!document()->page()
-        || !document()->page()->settings().needsSiteSpecificQuirks()
+    if (!document().page()
+        || !document().page()->settings().needsSiteSpecificQuirks()
         || hasFallbackContent()
         || !equalIgnoringCase(classId(), "clsid:02BF25D5-8C17-4B23-BC80-D3488ABDDC6B"))
         return false;
 
-    RefPtr<NodeList> metaElements = document()->getElementsByTagName(HTMLNames::metaTag.localName());
+    RefPtr<NodeList> metaElements = document().getElementsByTagName(HTMLNames::metaTag.localName());
     unsigned length = metaElements->length();
     for (unsigned i = 0; i < length; ++i) {
         ASSERT(metaElements->item(i)->isHTMLElement());
         HTMLMetaElement* metaElement = static_cast<HTMLMetaElement*>(metaElements->item(i));
         if (equalIgnoringCase(metaElement->name(), "generator") && metaElement->content().startsWith("Mac OS X Server Web Services Server", false))
             return true;
     }
 
     return false;
 }
@@ skipping 58 matching lines @@
         return;
 
     bool success = beforeLoadAllowedLoad && hasValidClassId() && requestObject(url, serviceType, paramNames, paramValues);
     if (!success && fallbackContent)
         renderFallbackContent();
 }
 
 bool HTMLObjectElement::rendererIsNeeded(const NodeRenderingContext& context)
 {
     // FIXME: This check should not be needed, detached documents never render!
-    Frame* frame = document()->frame();
+    Frame* frame = document().frame();
     if (!frame)
         return false;
 
     return HTMLPlugInImageElement::rendererIsNeeded(context);
 }
 
 Node::InsertionNotificationRequest HTMLObjectElement::insertedInto(ContainerNode* insertionPoint)
 {
     HTMLPlugInImageElement::insertedInto(insertionPoint);
     FormAssociatedElement::insertedInto(insertionPoint);
@@ skipping 24 matching lines @@
 const AtomicString& HTMLObjectElement::imageSourceURL() const
 {
     return getAttribute(dataAttr);
 }
 
 // FIXME: Remove this hack.
 void HTMLObjectElement::reattachFallbackContent()
 {
     // This can happen inside of attach() in the middle of a recalcStyle so we need to
     // reattach synchronously here.
-    if (document()->inStyleRecalc())
+    if (document().inStyleRecalc())
         reattach();
     else
         lazyReattach();
 }
 
 void HTMLObjectElement::renderFallbackContent()
 {
     if (useFallbackContent())
         return;
 
@@ skipping 56 matching lines @@
             // FIXME: Use of isRecognizedTagName is almost certainly wrong here.
             if (isRecognizedTagName(element->tagQName()) && !element->hasTagName(paramTag))
                 isNamedItem = false;
         } else if (child->isTextNode()) {
             if (!toText(child)->containsOnlyWhitespace())
                 isNamedItem = false;
         } else
             isNamedItem = false;
         child = child->nextSibling();
     }
-    if (isNamedItem != wasNamedItem && document()->isHTMLDocument()) {
-        HTMLDocument* document = toHTMLDocument(this->document());
+    if (isNamedItem != wasNamedItem && document().isHTMLDocument()) {
+        HTMLDocument* document = toHTMLDocument(&this->document());
         if (isNamedItem) {
             document->addNamedItem(getNameAttribute());
             document->addExtraNamedItem(getIdAttribute());
         } else {
             document->removeNamedItem(getNameAttribute());
             document->removeExtraNamedItem(getIdAttribute());
         }
     }
     m_docNamedItem = isNamedItem;
 }
@@ skipping 14 matching lines @@
             return true;
     }
 
     return false;
 }
 
 void HTMLObjectElement::addSubresourceAttributeURLs(ListHashSet<KURL>& urls) const
 {
     HTMLPlugInImageElement::addSubresourceAttributeURLs(urls);
 
-    addSubresourceURL(urls, document()->completeURL(getAttribute(dataAttr)));
+    addSubresourceURL(urls, document().completeURL(getAttribute(dataAttr)));
 
     // FIXME: Passing a string that starts with "#" to the completeURL function does
     // not seem like it would work. The image element has similar but not identical code.
     const AtomicString& useMap = getAttribute(usemapAttr);
     if (useMap.startsWith('#'))
-        addSubresourceURL(urls, document()->completeURL(useMap));
+        addSubresourceURL(urls, document().completeURL(useMap));
 }
 
 void HTMLObjectElement::didMoveToNewDocument(Document* oldDocument)
 {
     FormAssociatedElement::didMoveToNewDocument(oldDocument);
     HTMLPlugInImageElement::didMoveToNewDocument(oldDocument);
 }
 
 bool HTMLObjectElement::appendFormData(FormDataList& encoding, bool)
 {
     if (name().isEmpty())
         return false;
 
     Widget* widget = pluginWidget();
     if (!widget || !widget->isPluginView())
         return false;
     String value;
     if (!toPluginView(widget)->getFormValue(value))
         return false;
     encoding.appendData(name(), value);
     return true;
 }
 
 HTMLFormElement* HTMLObjectElement::virtualForm() const
 {
     return FormAssociatedElement::form();
 }
 
 }